PMD Results

The following document contains the results of PMD.

Summary

Files Errors
83 430

Files

Files Violations
org/webmacro/Broker.java 2
org/webmacro/Context.java 1
org/webmacro/URLTemplateLoader.java 3
org/webmacro/adapter/jsp/TemplateTag.java 2
org/webmacro/adapter/spring/WebMacroView.java 1
org/webmacro/adapter/spring/WebMacroViewResolver.java 2
org/webmacro/directive/ArgsHolder.java 5
org/webmacro/directive/BeanDirective.java 3
org/webmacro/directive/DefaultDirective.java 1
org/webmacro/directive/DirectiveBuilder.java 1
org/webmacro/directive/DirectiveProvider.java 4
org/webmacro/directive/EvalDirective.java 2
org/webmacro/directive/IfDirective.java 1
org/webmacro/directive/TempletDirective.java 1
org/webmacro/engine/Argument.java 3
org/webmacro/engine/Block.java 4
org/webmacro/engine/GlobalVariable.java 3
org/webmacro/engine/IntrospectionUtils.java 1
org/webmacro/engine/ListBuilder.java 2
org/webmacro/engine/MacroAdapter.java 4
org/webmacro/engine/MacroBuildContext.java 2
org/webmacro/engine/MacroBuilder.java 3
org/webmacro/engine/NullBuilder.java 1
org/webmacro/engine/ParserProvider.java 2
org/webmacro/engine/PropertyOperatorCache.java 28
org/webmacro/engine/PropertyVariable.java 3
org/webmacro/engine/QuotedStringBuilder.java 3
org/webmacro/engine/SimplePropertyVariable.java 3
org/webmacro/engine/StaticClassWrapper.java 1
org/webmacro/engine/StringMacroAdapter.java 3
org/webmacro/engine/TemplateDumper.java 1
org/webmacro/engine/UndefinedMacro.java 3
org/webmacro/engine/WMTemplate.java 1
org/webmacro/parser/ASCII_CharStream.java 15
org/webmacro/parser/BackupCharStream.java 15
org/webmacro/parser/ParserBlockBuilder.java 1
org/webmacro/parser/WMParser_impl.java 149
org/webmacro/parser/WMParser_implTokenManager.java 27
org/webmacro/resource/BrokerTemplateLoader.java 1
org/webmacro/resource/BrokerTemplateProvider.java 2
org/webmacro/resource/BrokerTemplateProviderHelper.java 4
org/webmacro/resource/DelegatingTemplateProvider.java 2
org/webmacro/resource/ReloadingCacheManager.java 1
org/webmacro/resource/TemplateProvider.java 4
org/webmacro/resource/URLTemplate.java 1
org/webmacro/resource/URLTemplateProvider.java 13
org/webmacro/resource/UrlProvider.java 2
org/webmacro/servlet/CGI_Impersonator.java 19
org/webmacro/servlet/CookieJar.java 3
org/webmacro/servlet/ErrorHandler.java 1
org/webmacro/servlet/Form.java 6
org/webmacro/servlet/FormList.java 3
org/webmacro/servlet/ListUtil.java 1
org/webmacro/servlet/LocaleTool.java 1
org/webmacro/servlet/Servlet20Broker.java 1
org/webmacro/servlet/Servlet22Broker.java 1
org/webmacro/servlet/TemplateTool.java 2
org/webmacro/servlet/TextTool.java 1
org/webmacro/servlet/WMServlet.java 1
org/webmacro/tools/CheckTemplates.java 1
org/webmacro/util/ArrayIterator.java 3
org/webmacro/util/Base64.java 4
org/webmacro/util/ByteBufferOutputStream.java 2
org/webmacro/util/CastUtil.java 2
org/webmacro/util/DictionaryTool.java 8
org/webmacro/util/EncodingCache.java 2
org/webmacro/util/EnumIterator.java 3
org/webmacro/util/Instantiator.java 1
org/webmacro/util/LogFile.java 2
org/webmacro/util/LogSystem.java 1
org/webmacro/util/PrimitiveArrayIterator.java 3
org/webmacro/util/Settings.java 2
org/webmacro/util/WMEval.java 1
/unit/org/webmacro/TestContext.java 1
/unit/org/webmacro/TestMultipleInstances.java 1
/unit/org/webmacro/parser/TestBackupCharStream.java 2
/unit/org/webmacro/template/AbstractVariableTestCase.java 1
/unit/org/webmacro/template/TestAbuse.java 1
/unit/org/webmacro/template/TestArithmetic.java 1
/unit/org/webmacro/template/TestContextToolAccess.java 2
/unit/org/webmacro/template/TestGetSet.java 1
/unit/org/webmacro/template/TestPerformanceAreas.java 6
/unit/org/webmacro/template/TestSyntheticTemplate.java 2

org/webmacro/Broker.java

Violation Line
Avoid empty 'if' statements 357
These nested if statements could be combined 406

org/webmacro/Context.java

Violation Line
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 597

org/webmacro/URLTemplateLoader.java

Violation Line
No need to import a type that's in the same package 25
No need to import a type that's in the same package 26
Avoid unused imports such as 'java.io.File' 30

org/webmacro/adapter/jsp/TemplateTag.java

Violation Line
Avoid unused imports such as 'org.webmacro.servlet.ServletBroker' 5
Avoid unused imports such as 'java.io.IOException' 16

org/webmacro/adapter/spring/WebMacroView.java

Violation Line
Avoid unused imports such as 'org.springframework.beans.BeansException' 3

org/webmacro/adapter/spring/WebMacroViewResolver.java

Violation Line
Avoid unused imports such as 'org.springframework.web.servlet.View' 6
Avoid unused imports such as 'java.util.Locale' 17

org/webmacro/directive/ArgsHolder.java

Violation Line
Unnecessary final modifier in final class 55
Unnecessary final modifier in final class 78
Unnecessary final modifier in final class 86
Unnecessary final modifier in final class 97
Unnecessary final modifier in final class 114

org/webmacro/directive/BeanDirective.java

Violation Line
Avoid empty catch blocks 279
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 311
Avoid unused formal parameters such as 'bc' 327

org/webmacro/directive/DefaultDirective.java

Violation Line
Avoid unused private fields such as 'DEFAULT_TO' 40

org/webmacro/directive/DirectiveBuilder.java

Violation Line
An empty statement (semicolon) not part of a loop 237

org/webmacro/directive/DirectiveProvider.java

Violation Line
Unnecessary final modifier in final class 86
Unnecessary final modifier in final class 98
Avoid empty catch blocks 149
Unnecessary final modifier in final class 173

org/webmacro/directive/EvalDirective.java

Violation Line
Avoid empty catch blocks 148
Avoid empty catch blocks 166

org/webmacro/directive/IfDirective.java

Violation Line
Avoid empty 'if' statements 172

org/webmacro/directive/TempletDirective.java

Violation Line
Avoid unused private fields such as '_templateTool' 49

org/webmacro/engine/Argument.java

Violation Line
Unnecessary final modifier in final class 51
Unnecessary final modifier in final class 59
Unnecessary final modifier in final class 69

org/webmacro/engine/Block.java

Violation Line
Unnecessary final modifier in final class 80
Unnecessary final modifier in final class 289
Unnecessary final modifier in final class 300
Unnecessary final modifier in final class 318

org/webmacro/engine/GlobalVariable.java

Violation Line
Unnecessary final modifier in final class 49
Unnecessary final modifier in final class 60
Unnecessary final modifier in final class 77

org/webmacro/engine/IntrospectionUtils.java

Violation Line
Avoid empty catch blocks 117

org/webmacro/engine/ListBuilder.java

Violation Line
Unnecessary final modifier in final class 50
Unnecessary final modifier in final class 63

org/webmacro/engine/MacroAdapter.java

Violation Line
Unnecessary final modifier in final class 50
Unnecessary final modifier in final class 58
Unnecessary final modifier in final class 66
Unnecessary final modifier in final class 81

org/webmacro/engine/MacroBuildContext.java

Violation Line
Avoid unused private fields such as 'macro' 41
Avoid unused private fields such as 'args' 42

org/webmacro/engine/MacroBuilder.java

Violation Line
Avoid unused private fields such as 'colNo' 41
Avoid unused private fields such as 'lineNo' 41
Avoid unused private fields such as 'nullArgs' 42

org/webmacro/engine/NullBuilder.java

Violation Line
Unnecessary final modifier in final class 30

org/webmacro/engine/ParserProvider.java

Violation Line
Unnecessary final modifier in final class 53
Unnecessary final modifier in final class 106

org/webmacro/engine/PropertyOperatorCache.java

Violation Line
Unnecessary final modifier in final class 48
Unnecessary final modifier in final class 112
Unnecessary final modifier in final class 126
Unnecessary final modifier in final class 151
Unnecessary final modifier in final class 171
Unnecessary final modifier in final class 189
Unnecessary final modifier in final class 218
Unnecessary final modifier in final class 234
These nested if statements could be combined 654
Unnecessary final modifier in final class 846
Avoid empty catch blocks 910
Avoid empty catch blocks 950
Avoid empty catch blocks 954
Unnecessary final modifier in final class 1146
Unnecessary final modifier in final class 1161
Unnecessary final modifier in final class 1190
Unnecessary final modifier in final class 1205
Unnecessary final modifier in final class 1227
Unnecessary final modifier in final class 1232
Avoid empty catch blocks 1389
Unnecessary final modifier in final class 1416
Unnecessary final modifier in final class 1421
Unnecessary final modifier in final class 1426
Unnecessary final modifier in final class 1432
Unnecessary final modifier in final class 1451
Unnecessary final modifier in final class 1456
Unnecessary final modifier in final class 1461
Unnecessary final modifier in final class 1469

org/webmacro/engine/PropertyVariable.java

Violation Line
Unnecessary final modifier in final class 49
Unnecessary final modifier in final class 60
Unnecessary final modifier in final class 76

org/webmacro/engine/QuotedStringBuilder.java

Violation Line
Unnecessary final modifier in final class 41
Avoid unused private fields such as 'debug' 121
Unnecessary final modifier in final class 173

org/webmacro/engine/SimplePropertyVariable.java

Violation Line
Unnecessary final modifier in final class 50
Unnecessary final modifier in final class 61
Unnecessary final modifier in final class 77

org/webmacro/engine/StaticClassWrapper.java

Violation Line
Unnecessary final modifier in final class 41

org/webmacro/engine/StringMacroAdapter.java

Violation Line
Unnecessary final modifier in final class 42
Unnecessary final modifier in final class 55
Unnecessary final modifier in final class 63

org/webmacro/engine/TemplateDumper.java

Violation Line
Avoid unused local variables such as 'context' 129

org/webmacro/engine/UndefinedMacro.java

Violation Line
Unnecessary final modifier in final class 44
Unnecessary final modifier in final class 58
Unnecessary final modifier in final class 71

org/webmacro/engine/WMTemplate.java

Violation Line
Avoid empty catch blocks 216

org/webmacro/parser/ASCII_CharStream.java

Violation Line
Unnecessary final modifier in final class 70
Unnecessary final modifier in final class 77
Unnecessary final modifier in final class 129
Unnecessary final modifier in final class 139
Unnecessary final modifier in final class 179
An empty statement (semicolon) not part of a loop 193
Unnecessary final modifier in final class 211
Unnecessary final modifier in final class 221
Unnecessary final modifier in final class 226
Unnecessary final modifier in final class 231
Unnecessary final modifier in final class 236
Unnecessary final modifier in final class 241
Unnecessary final modifier in final class 246
Unnecessary final modifier in final class 327
Unnecessary final modifier in final class 338

org/webmacro/parser/BackupCharStream.java

Violation Line
Unnecessary final modifier in final class 72
Unnecessary final modifier in final class 79
Unnecessary final modifier in final class 139
Unnecessary final modifier in final class 149
Unnecessary final modifier in final class 189
An empty statement (semicolon) not part of a loop 203
Unnecessary final modifier in final class 222
Unnecessary final modifier in final class 232
Unnecessary final modifier in final class 237
Unnecessary final modifier in final class 242
Unnecessary final modifier in final class 247
Unnecessary final modifier in final class 252
Unnecessary final modifier in final class 257
Unnecessary final modifier in final class 349
Unnecessary final modifier in final class 369

org/webmacro/parser/ParserBlockBuilder.java

Violation Line
Avoid unused private methods such as 'eatOneWs' 75

org/webmacro/parser/WMParser_impl.java

Violation Line
Avoid duplicate imports such as 'org.webmacro.directive.Directive' 9
Avoid duplicate imports such as 'org.webmacro.directive.DirectiveProvider' 10
Avoid duplicate imports such as 'org.webmacro.directive.DirectiveBuilder' 11
An empty statement (semicolon) not part of a loop 116
Avoid unused local variables such as 'entryState' 128
These nested if statements could be combined 271
An empty statement (semicolon) not part of a loop 376
An empty statement (semicolon) not part of a loop 402
An empty statement (semicolon) not part of a loop 406
An empty statement (semicolon) not part of a loop 425
An empty statement (semicolon) not part of a loop 435
An empty statement (semicolon) not part of a loop 447
An empty statement (semicolon) not part of a loop 455
An empty statement (semicolon) not part of a loop 460
An empty statement (semicolon) not part of a loop 471
An empty statement (semicolon) not part of a loop 479
An empty statement (semicolon) not part of a loop 490
An empty statement (semicolon) not part of a loop 500
An empty statement (semicolon) not part of a loop 527
An empty statement (semicolon) not part of a loop 541
An empty statement (semicolon) not part of a loop 550
Do not use 'if' statements that are always true or always false 552
An empty statement (semicolon) not part of a loop 564
An empty statement (semicolon) not part of a loop 573
Do not use 'if' statements that are always true or always false 575
Avoid unused local variables such as 't' 580
An empty statement (semicolon) not part of a loop 587
An empty statement (semicolon) not part of a loop 596
Avoid unused local variables such as 't' 601
An empty statement (semicolon) not part of a loop 608
An empty statement (semicolon) not part of a loop 617
Avoid unused local variables such as 't' 622
An empty statement (semicolon) not part of a loop 629
An empty statement (semicolon) not part of a loop 638
Avoid unused local variables such as 't' 643
An empty statement (semicolon) not part of a loop 650
An empty statement (semicolon) not part of a loop 659
An empty statement (semicolon) not part of a loop 671
An empty statement (semicolon) not part of a loop 680
Do not use 'if' statements that are always true or always false 683
These nested if statements could be combined 683
An empty statement (semicolon) not part of a loop 695
An empty statement (semicolon) not part of a loop 704
Do not use 'if' statements that are always true or always false 706
An empty statement (semicolon) not part of a loop 719
An empty statement (semicolon) not part of a loop 728
Do not use 'if' statements that are always true or always false 731
Do not use 'if' statements that are always true or always false 764
An empty statement (semicolon) not part of a loop 778
An empty statement (semicolon) not part of a loop 794
An empty statement (semicolon) not part of a loop 811
Do not use 'if' statements that are always true or always false 834
An empty statement (semicolon) not part of a loop 862
An empty statement (semicolon) not part of a loop 904
Do not use 'if' statements that are always true or always false 942
Avoid unused local variables such as 'entryState' 948
Do not use 'if' statements that are always true or always false 963
An empty statement (semicolon) not part of a loop 1005
An empty statement (semicolon) not part of a loop 1015
An empty statement (semicolon) not part of a loop 1038
An empty statement (semicolon) not part of a loop 1048
An empty statement (semicolon) not part of a loop 1071
An empty statement (semicolon) not part of a loop 1081
An empty statement (semicolon) not part of a loop 1088
An empty statement (semicolon) not part of a loop 1115
An empty statement (semicolon) not part of a loop 1125
An empty statement (semicolon) not part of a loop 1148
An empty statement (semicolon) not part of a loop 1158
An empty statement (semicolon) not part of a loop 1181
An empty statement (semicolon) not part of a loop 1191
An empty statement (semicolon) not part of a loop 1214
An empty statement (semicolon) not part of a loop 1224
An empty statement (semicolon) not part of a loop 1231
Do not use 'if' statements that are always true or always false 1233
An empty statement (semicolon) not part of a loop 1260
An empty statement (semicolon) not part of a loop 1270
Do not use 'if' statements that are always true or always false 1276
An empty statement (semicolon) not part of a loop 1304
An empty statement (semicolon) not part of a loop 1313
An empty statement (semicolon) not part of a loop 1320
An empty statement (semicolon) not part of a loop 1333
An empty statement (semicolon) not part of a loop 1342
An empty statement (semicolon) not part of a loop 1349
Do not use 'if' statements that are always true or always false 1351
Do not use 'if' statements that are always true or always false 1360
An empty statement (semicolon) not part of a loop 1379
An empty statement (semicolon) not part of a loop 1389
An empty statement (semicolon) not part of a loop 1396
An empty statement (semicolon) not part of a loop 1409
An empty statement (semicolon) not part of a loop 1419
An empty statement (semicolon) not part of a loop 1426
An empty statement (semicolon) not part of a loop 1432
Do not use 'if' statements that are always true or always false 1434
An empty statement (semicolon) not part of a loop 1448
Do not use 'if' statements that are always true or always false 1450
An empty statement (semicolon) not part of a loop 1469
An empty statement (semicolon) not part of a loop 1478
An empty statement (semicolon) not part of a loop 1516
Do not use 'if' statements that are always true or always false 1537
An empty statement (semicolon) not part of a loop 1548
An empty statement (semicolon) not part of a loop 1558
An empty statement (semicolon) not part of a loop 1578
Do not use 'if' statements that are always true or always false 1586
Do not use 'if' statements that are always true or always false 1588
An empty statement (semicolon) not part of a loop 1599
An empty statement (semicolon) not part of a loop 1609
An empty statement (semicolon) not part of a loop 1629
Do not use 'if' statements that are always true or always false 1637
Do not use 'if' statements that are always true or always false 1639
Do not use 'if' statements that are always true or always false 1672
An empty statement (semicolon) not part of a loop 1691
An empty statement (semicolon) not part of a loop 1700
An empty statement (semicolon) not part of a loop 1704
Do not use 'if' statements that are always true or always false 1707
Do not use 'if' statements that are always true or always false 1709
Do not use 'if' statements that are always true or always false 1710
Do not use 'if' statements that are always true or always false 1711
Do not use 'if' statements that are always true or always false 1712
Do not use 'if' statements that are always true or always false 1713
Do not use 'if' statements that are always true or always false 1714
Do not use 'if' statements that are always true or always false 1715
Do not use 'if' statements that are always true or always false 1717
An empty statement (semicolon) not part of a loop 1728
An empty statement (semicolon) not part of a loop 1738
An empty statement (semicolon) not part of a loop 1747
Do not use 'if' statements that are always true or always false 1752
An empty statement (semicolon) not part of a loop 1762
An empty statement (semicolon) not part of a loop 1772
An empty statement (semicolon) not part of a loop 1781
Do not use 'if' statements that are always true or always false 1786
Do not use 'if' statements that are always true or always false 1793
Avoid unused local variables such as 's' 1809
An empty statement (semicolon) not part of a loop 1820
An empty statement (semicolon) not part of a loop 1842
Do not use 'if' statements that are always true or always false 1870
Avoid unused local variables such as 'o' 1876
Avoid unused local variables such as 'o' 1911
An empty statement (semicolon) not part of a loop 1999
An empty statement (semicolon) not part of a loop 2055
An empty statement (semicolon) not part of a loop 2068
Do not use 'if' statements that are always true or always false 2113
An empty statement (semicolon) not part of a loop 2135
An empty statement (semicolon) not part of a loop 2181
An empty statement (semicolon) not part of a loop 2186
Do not use 'if' statements that are always true or always false 2200
An empty statement (semicolon) not part of a loop 2235
Do not use 'if' statements that are always true or always false 2239
An empty statement (semicolon) not part of a loop 2259
Do not use 'if' statements that are always true or always false 2305

org/webmacro/parser/WMParser_implTokenManager.java

Violation Line
Avoid duplicate imports such as 'org.webmacro.directive.Directive' 8
Avoid unused imports such as 'org.webmacro.directive.Directive' 8
Avoid duplicate imports such as 'org.webmacro.directive.DirectiveProvider' 9
Avoid unused imports such as 'org.webmacro.directive.DirectiveProvider' 9
Avoid duplicate imports such as 'org.webmacro.directive.DirectiveBuilder' 10
Avoid unused imports such as 'org.webmacro.directive.DirectiveBuilder' 10
Avoid unused imports such as 'org.webmacro.directive.Directive.ArgDescriptor' 11
Avoid unused imports such as 'org.webmacro.directive.Directive.OptionChoice' 12
Avoid unused imports such as 'org.webmacro.directive.Directive.Subdirective' 13
Avoid unused private methods such as 'jjCheckNAddTwoStates' 186
Avoid unused private methods such as 'jjCheckNAddStates' 191
Avoid unused private methods such as 'jjCheckNAddStates' 197
Avoid unused local variables such as 'j' 215
These nested if statements could be combined 238
Avoid unused formal parameters such as 'active0' 328
Avoid unused private methods such as 'jjStartNfa_1' 336
Avoid unused local variables such as 'j' 369
These nested if statements could be combined 384
Avoid unused local variables such as 'j' 493
Avoid unused local variables such as 'l' 517
Avoid unused local variables such as 'j' 913
These nested if statements could be combined 928
Avoid unused formal parameters such as 'active0' 1190
Avoid unused private methods such as 'jjStartNfa_0' 1198
Avoid unused local variables such as 'j' 1231
These nested if statements could be combined 1246
Avoid unused local variables such as 'kind' 1464

org/webmacro/resource/BrokerTemplateLoader.java

Violation Line
These nested if statements could be combined 37

org/webmacro/resource/BrokerTemplateProvider.java

Violation Line
Unnecessary final modifier in final class 54
Unnecessary final modifier in final class 59

org/webmacro/resource/BrokerTemplateProviderHelper.java

Violation Line
Avoid unused private fields such as '_cacheDuration' 53
Unnecessary final modifier in final class 93
Unnecessary final modifier in final class 188
These nested if statements could be combined 194

org/webmacro/resource/DelegatingTemplateProvider.java

Violation Line
Avoid unused private fields such as 'broker' 70
These nested if statements could be combined 90

org/webmacro/resource/ReloadingCacheManager.java

Violation Line
Avoid unused private fields such as 'reloadContext' 40

org/webmacro/resource/TemplateProvider.java

Violation Line
Avoid empty catch blocks 68
Unnecessary final modifier in final class 140
Unnecessary final modifier in final class 148
Unnecessary final modifier in final class 215

org/webmacro/resource/URLTemplate.java

Violation Line
Avoid empty catch blocks 203

org/webmacro/resource/URLTemplateProvider.java

Violation Line
Avoid unused private fields such as 'CONTEXT_PREFIX_LENGTH' 128
Unnecessary final modifier in final class 173
Unnecessary final modifier in final class 224
Unnecessary final modifier in final class 239
Unnecessary final modifier in final class 296
Unnecessary final modifier in final class 302
Avoid empty catch blocks 324
Unnecessary final modifier in final class 336
Unnecessary final modifier in final class 472
Unnecessary final modifier in final class 497
These nested if statements could be combined 521
Unnecessary final modifier in final class 536
Unnecessary final modifier in final class 555

org/webmacro/resource/UrlProvider.java

Violation Line
Unnecessary final modifier in final class 59
Unnecessary final modifier in final class 82

org/webmacro/servlet/CGI_Impersonator.java

Violation Line
Unnecessary final modifier in final class 69
Unnecessary final modifier in final class 77
Unnecessary final modifier in final class 86
Unnecessary final modifier in final class 94
Unnecessary final modifier in final class 102
Unnecessary final modifier in final class 112
Unnecessary final modifier in final class 120
Unnecessary final modifier in final class 129
Unnecessary final modifier in final class 140
Unnecessary final modifier in final class 148
Unnecessary final modifier in final class 156
Unnecessary final modifier in final class 164
Unnecessary final modifier in final class 172
Unnecessary final modifier in final class 180
Unnecessary final modifier in final class 188
Unnecessary final modifier in final class 196
Unnecessary final modifier in final class 204
Unnecessary final modifier in final class 212
Unnecessary final modifier in final class 220

org/webmacro/servlet/CookieJar.java

Violation Line
Unnecessary final modifier in final class 54
Unnecessary final modifier in final class 74
Unnecessary final modifier in final class 83

org/webmacro/servlet/ErrorHandler.java

Violation Line
Unnecessary final modifier in final class 99

org/webmacro/servlet/Form.java

Violation Line
Unnecessary final modifier in final class 60
Unnecessary final modifier in final class 80
Unnecessary final modifier in final class 111
Unnecessary final modifier in final class 126
Unnecessary final modifier in final class 136
Unnecessary final modifier in final class 145

org/webmacro/servlet/FormList.java

Violation Line
Unnecessary final modifier in final class 54
Unnecessary final modifier in final class 69
Unnecessary final modifier in final class 78

org/webmacro/servlet/ListUtil.java

Violation Line
Avoid empty catch blocks 720

org/webmacro/servlet/LocaleTool.java

Violation Line
Avoid empty catch blocks 136

org/webmacro/servlet/Servlet20Broker.java

Violation Line
Avoid empty catch blocks 192

org/webmacro/servlet/Servlet22Broker.java

Violation Line
Avoid empty catch blocks 286

org/webmacro/servlet/TemplateTool.java

Violation Line
Avoid unused private fields such as '_context' 32
Avoid unused private fields such as '_destroyed' 37

org/webmacro/servlet/TextTool.java

Violation Line
Avoid unused local variables such as 'tt' 408

org/webmacro/servlet/WMServlet.java

Violation Line
Avoid empty catch blocks 542

org/webmacro/tools/CheckTemplates.java

Violation Line
An empty statement (semicolon) not part of a loop 55

org/webmacro/util/ArrayIterator.java

Violation Line
Unnecessary final modifier in final class 51
Unnecessary final modifier in final class 60
Unnecessary final modifier in final class 75

org/webmacro/util/Base64.java

Violation Line
Unnecessary final modifier in final class 45
Unnecessary final modifier in final class 53
Unnecessary final modifier in final class 61
Unnecessary final modifier in final class 147

org/webmacro/util/ByteBufferOutputStream.java

Violation Line
Avoid unused private fields such as '_initialSize' 38
Unnecessary final modifier in final class 98

org/webmacro/util/CastUtil.java

Violation Line
Avoid unused local variables such as 'cu' 189
Avoid unused private methods such as 'print' 210

org/webmacro/util/DictionaryTool.java

Violation Line
Unnecessary final modifier in final class 40
Unnecessary final modifier in final class 73
Unnecessary final modifier in final class 81
Unnecessary final modifier in final class 89
Unnecessary final modifier in final class 97
Unnecessary final modifier in final class 105
Unnecessary final modifier in final class 113
Unnecessary final modifier in final class 121

org/webmacro/util/EncodingCache.java

Violation Line
An empty statement (semicolon) not part of a loop 155
An empty statement (semicolon) not part of a loop 214

org/webmacro/util/EnumIterator.java

Violation Line
Unnecessary final modifier in final class 52
Unnecessary final modifier in final class 61
Unnecessary final modifier in final class 75

org/webmacro/util/Instantiator.java

Violation Line
Avoid empty catch blocks 196

org/webmacro/util/LogFile.java

Violation Line
These nested if statements could be combined 82
These nested if statements could be combined 90

org/webmacro/util/LogSystem.java

Violation Line
Avoid unused private methods such as 'update' 256

org/webmacro/util/PrimitiveArrayIterator.java

Violation Line
Unnecessary final modifier in final class 56
Unnecessary final modifier in final class 65
Unnecessary final modifier in final class 80

org/webmacro/util/Settings.java

Violation Line
Avoid empty catch blocks 120
An empty statement (semicolon) not part of a loop 123

org/webmacro/util/WMEval.java

Violation Line
Avoid unused private fields such as 'out' 71

/unit/org/webmacro/TestContext.java

Violation Line
Avoid unused local variables such as 'o' 25

/unit/org/webmacro/TestMultipleInstances.java

Violation Line
Avoid unused local variables such as 'context' 55

/unit/org/webmacro/parser/TestBackupCharStream.java

Violation Line
Avoid empty catch blocks 83
Avoid empty catch blocks 130

/unit/org/webmacro/template/AbstractVariableTestCase.java

Violation Line
An empty statement (semicolon) not part of a loop 195

/unit/org/webmacro/template/TestAbuse.java

Violation Line
Avoid unused local variables such as 'jscriptnl' 130

/unit/org/webmacro/template/TestArithmetic.java

Violation Line
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 33

/unit/org/webmacro/template/TestContextToolAccess.java

Violation Line
Avoid unused imports such as 'java.util.Hashtable' 6
Avoid unused imports such as 'java.util.Map' 7

/unit/org/webmacro/template/TestGetSet.java

Violation Line
Avoid unused private fields such as 'bool' 95

/unit/org/webmacro/template/TestPerformanceAreas.java

Violation Line
Avoid unused private fields such as 'fileName' 27
Avoid unused local variables such as 'end' 83
Avoid unused local variables such as 'singleTet' 83
Avoid unused local variables such as 'tet' 83
Avoid unused local variables such as 'value' 87
Avoid unused local variables such as 'object' 88

/unit/org/webmacro/template/TestSyntheticTemplate.java

Violation Line
Avoid unused local variables such as 'value' 116
Avoid unused local variables such as 'value' 287